Project

General

Profile

Bug #1079

Workgroup not settable

Added by bigfoot65 about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
08/12/2013
Due date:
% Done:

0%


Description

The dashboard capability to change the Samba Workgroup is missing. It was previously located under Shares, Settings.

History

#1 Updated by cpg about 7 years ago

  • Subject changed from Workgroup to Workgroup not settable

The workgroup is still controlled by Amahi, it's just that we did not get to implementing the UI for it. So it just writes the default each time.

#2 Updated by bigfoot65 almost 7 years ago

  • Target version changed from amahi-7-0 to amahi-7-2

#3 Updated by bigfoot65 almost 7 years ago

  • Priority changed from Normal to High

#4 Updated by cpg over 6 years ago

  • Status changed from New to Feedback
  • Assignee changed from cpg to bigfoot65

this functionality has been implemented.

please test at alpha.amahi.org/tmp/hda-platform-7.1.7-1.x86_64.rpm

#5 Updated by bigfoot65 over 6 years ago

  • Assignee changed from bigfoot65 to cpg

Added new test RPM after installing mlocate. It is a required dependency.

The WorkGroup setting is absent from the UI.

http://i.imgur.com/RBtsjlh.png

Under Shares, the Settings section has nothing that is selectable.

#6 Updated by cpg over 6 years ago

the issue here is that the existing code does not account for systems without this value in them. this would fix it:

-               @workgroup = Setting.find_by_name('workgroup')
+               @workgroup = Setting.find_or_create_by(Setting::GENERAL, 'workgroup', 'WORKGROUP')

however, validation needs to be done with the data. i am investigating what the validation requirements should be.

#7 Updated by cpg over 6 years ago

looking at the SMB/CIFS specs, it looks like the workgroup should conservatively be at most 15 chars, matching this regular expression:

[a-zA-Z][a-zA-Z0-9]{14}

#8 Updated by cpg over 6 years ago

  • Status changed from Feedback to Closed

#9 Updated by kikkegek over 6 years ago

why is this closed? Its still not settable in my dashbnoard

#10 Updated by bigfoot65 over 6 years ago

kikkegek
We are about to release an update to Amahi 7 that corrects this issue. One patches are done for new release, the bug is closed.

Also available in: Atom