Project

General

Profile

Bug #1370

more than one server active seems to trigger a bug where the second server fails

Added by cpg about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
05/17/2014
Due date:
% Done:

0%


Description

while testing something, we noticed that when more than one server is active, accessing the shares of one and then switching to the other makes things not work.

it would appear as if the first GET /shares was to be cached, so switching to the other server does not seem to issue a GET /shares API call.

the app crashes, which seems like a second bug -- a 404 should not crash the app.

History

#1 Updated by ming about 7 years ago

Not sure why it happens, OkHttp & Retrofit somehow don’t add the If-None-Match header. Maybe it is related to the lack of Cache-Control header.

#2 Updated by ming about 7 years ago

Just filed the OkHttp bug.

#3 Updated by cpg about 7 years ago

Did you try with HttpResponseCache not set?

If it works let's use it for now without HttpResponseCache.

#4 Updated by cpg about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to ming

#5 Updated by ming about 7 years ago

Disabled the cache for now, let’s see how things will work out in the future.

#6 Updated by ming about 7 years ago

I got a response. Based on this answer I tend to agree that the Vary header will give better semantics.

#7 Updated by ming about 7 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from ming to cpg

#8 Updated by cpg about 7 years ago

i think it would be adding this header as a return to each call that requires session to be set

Vary: Session

#9 Updated by ming about 7 years ago

As I believe this bug is the closest one related to caching. I pushed a response-cache branch. As I see it works, and can be better after OkHttp 2.+ update which is done only at the apps branch at moment. I cannot test multiple servers behaviour obviously.

#10 Updated by cpg about 7 years ago

  • Priority changed from Medium to Normal

this appears to work well. tested with remote access via the proxy, with multiple servers.

we will not merge this to master yet. not until we have a chance to release the origin server with Very: Session in it.

releasing without the origin support for Vary: Session will lead to confused users and also possibly worried users that their data could be corrupted.

i will keep it on feedback until we have released the origin server with this support.

#11 Updated by cpg about 7 years ago

  • Status changed from Feedback to Closed

this has been deployed in the origin servers.

Also available in: Atom