Project

General

Profile

Bug #1778

feedback on version v0.5.3 of the disk wizard on a VM

Added by cpg about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Medium
Assignee:
Target version:
-
Start date:
08/17/2015
Due date:
% Done:

0%


Description

Tested DW on Fedora 21. Added two drives, one virtual and one SATA. This all was done with a Proxmox VM.

The results were not good:

http://i.imgur.com/ZyCTWnw.png
Should there be a legend that indicates a star means new. The mouse over shows it as new, but not sure if users will see that.

http://i.imgur.com/xwFs9Zy.png
Disk graphs don't appear to be loading. They say "Loading..." but nothing ever shows up.

http://i.imgur.com/3hhYWim.png
Not sure what is supposed to show up before the disk is formatted and mounted.

http://i.imgur.com/zdE0vrm.png
Got this when formatting and mounting drive. Labeled it "test1"

http://i.imgur.com/0j5bheg.png
Tried another disk drive and got the same error.

sysinfo.txt View (10.6 KB) bigfoot65, 08/17/2015 05:45 PM

dw_debug.log View (68.5 KB) bigfoot65, 08/19/2015 01:00 PM

dsw.log View (34.2 KB) bigfoot65, 08/19/2015 01:00 PM

dsw.log View (12.6 KB) bigfoot65, 08/19/2015 04:09 PM

dw_debug.log View (97.1 KB) bigfoot65, 08/19/2015 04:09 PM

History

#1 Updated by bigfoot65 about 5 years ago

Attaching the output of:
fpaste --sysinfo

#2 Updated by ahmedkamal about 5 years ago

I need more information
Could you give me the debug url ?

#3 Updated by bigfoot65 about 5 years ago

It will not generate a debug URL. Tried each new disk and same result. Says it's generating the URL, but one never appears.

#4 Updated by bigfoot65 about 5 years ago

Running the debug mode where it shows commands but does not actually execute shows some concerns:

1     lsblk     /dev/sdb -b -P -o VENDOR,MODEL,TYPE,SIZE,KNAME,UUID,LABEL,MOUNTPOINT,FSTYPE,RM
2     parted     -sm /dev/sdb unit b print free
3     parted     -sm /dev/sdb unit b print free
4     parted     /dev/sdb -s -a optimal unit MB mkpart primary ext3 1 -- -1
5     partprobe     
6     udevadm     trigger
7     hdparm     -z /dev/sdb
8     partprobe     
9     udevadm     trigger
10     hdparm     -z /dev/sdb
11     lsblk     /dev/sdb -b -P -o VENDOR,MODEL,TYPE,SIZE,KNAME,UUID,LABEL,MOUNTPOINT,FSTYPE,RM 

I chose ext4 for type yet the command shows ext3. Also I see one command (2 and 3) listed twice.

#5 Updated by ahmedkamal about 5 years ago

could you give me these log files
/var/hda/platform/html/log/dw_debug.log
/var/hda/apps/520ut3lo6w/elevated/dsw.log

#6 Updated by bigfoot65 about 5 years ago

Logs attached.

#7 Updated by ahmedkamal about 5 years ago

  • Status changed from Feedback to New
  • Assignee deleted (ahmedkamal)

I get the bug
the output of

 parted -sm /dev/sdb unit b print free 

differs when there is no partition table
on my devices (flash disk and virtual box VD) it's output is 'unknown'
but in your device it's output is 'false'
your's
[INFO  2015-08-18 19:19:15 18079] |Device|>|format_job|:partition_table is 'false'

mine
[INFO  2015-08-19 21:57:10 2517] |Device|>|format_job|:partition_table is 'unknown'

#8 Updated by ahmedkamal about 5 years ago

  • Status changed from New to Feedback
  • Assignee set to ahmedkamal

#9 Updated by ahmedkamal about 5 years ago

  • Priority changed from Normal to Medium

it's fixed here
it needs to be tested again with v0.5.3

#10 Updated by cpg about 5 years ago

  • Subject changed from feedback on version v0.5.1 of the disk wizard on a VM to feedback on version v0.5.3 of the disk wizard on a VM

i made a new release, v0.5.3, ready for testing and feedback with the fixed that @ahmedkamal pointed out.

#11 Updated by bigfoot65 about 5 years ago

Received an error saying "command hdparm is not known". I checked and it's installed on the HDA.

http://i.imgur.com/TYA60MA.png

#12 Updated by cpg about 5 years ago

ah. the app install script needs to be updated to have a proper elevated script. he'll do that now.

#13 Updated by ahmedkamal about 5 years ago

  • Assignee changed from ahmedkamal to bigfoot65

the app was updated

#14 Updated by bigfoot65 about 5 years ago

  • Assignee changed from bigfoot65 to ahmedkamal

We have success :) Worked perfectly.

I do have a concern though. It reflects existing disks/partitions with data on them which makes sense except the OS partition. You could in fact format the OS drive and crash the system the way it appears.

Is there any way to block out the OS drive from being available in the DW?

#15 Updated by ahmedkamal about 5 years ago

this issue discussed before here
tmkasun propose that we can hide all mounted partitions

But I am not sure it's the best solution
so could you propose another solution please
what about hide partition which mounted in '/boot' or '/' ?

#16 Updated by ahmedkamal about 5 years ago

  • Assignee changed from ahmedkamal to bigfoot65

#17 Updated by bigfoot65 about 5 years ago

I think hiding mounted partitions would be good, at least if they are the OS partitions such as / or /boot.

Recommend we try that and I will test again.

#18 Updated by bigfoot65 about 5 years ago

  • Assignee changed from bigfoot65 to ahmedkamal

#19 Updated by ahmedkamal about 5 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from ahmedkamal to bigfoot65

now we hide all mounted partitions in v0.6.0
with these green paths
could you test it again?

#20 Updated by bigfoot65 about 5 years ago

  • Status changed from Closed to Feedback
  • Assignee changed from bigfoot65 to ahmedkamal

Tested new version.

Deice /dev/vda is showing and this is the OS drive.
http://i.imgur.com/oPy8ivx.png

Tried to format it. Obviously it failed.
http://i.imgur.com/pdvkesr.png

Formatted and mounted two new drives successfully.
http://i.imgur.com/DIzaKfG.png

Is there any way to prevent this OS drive from showing at all?

Not sure if this is related to it being a VM or maybe due to LVM being used. Fedora defaults to using LVM I believe on install.

Everything else appears to be working good.

#21 Updated by ahmedkamal about 5 years ago

  • Assignee changed from ahmedkamal to bigfoot65

till now we avoid dealing with LVM partitions
IMO about hide the OS drive I think OS disk may have also a data partitions which important to be visible
and it's common that the users machine has only one drive with OS and data partitions
the other tools like Gnome Disk utility and Gparted show the OS partition

#22 Updated by bigfoot65 about 5 years ago

  • Assignee changed from bigfoot65 to ahmedkamal

This is true.

Maybe a warning on the screen about the OS drive? If nothing else, maybe just leave things as there were and not hide partitions at all.

You make a good point as the Gnome Disk Utility does show all and could allow formatting an OS partition.

How about a pop up warning if the OS partition or one with data is selected for format? Something like "Are you sure you want to format this partition?"

#23 Updated by ahmedkamal about 5 years ago

that's need dealing with LVM partition to know if it's an OS partition or not
like get the mount point of the partitions that the LVM partition has.
and after discuss that with cpg he said we generally like to avoid it

#24 Updated by ahmedkamal about 5 years ago

now we show a warning message after choosing a LVM partition
does that a suitable solution ?
NOTE: we haven't release this yet

#25 Updated by ahmedkamal about 5 years ago

  • Assignee changed from ahmedkamal to bigfoot65

#26 Updated by bigfoot65 about 5 years ago

How about it say "The Amahi team does not recommend use of LVM. Click here for details"

Also once the app has been updated, please let me know and I will test.

#27 Updated by cpg about 5 years ago

  • Status changed from Feedback to Closed

Also available in: Atom