Project

General

Profile

Bug #2360

Upgrade to Greyhole 0.12.3 (was 0.10.17)

Added by bigfoot65 over 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Medium
Assignee:
cpg
Target version:
apps - amahi-11
Start date:
11/04/2018
Due date:
% Done:

0%

Description

https://github.com/gboudreau/Greyhole/archive/0.10.17.tar.gz

  • New: VFS modules for Samba 4.8 & 4.9
  • Improvement: check that the required PHP extensions are enabled, before executing (anything)
  • Bugfix: Samba VFS module failed to log write operations that occurred asynchronously, triggering VFS' pwrite_send & pwrite_recv instead of pwrite. This resulted in Greyhole not noticing any file write ops, between the file open & close ops.
  • Bugfix: folder where we need to put the VFS module symlink might not exist
  • Crashfix: Samba 4.5+ would sometimes crash; adding our own pwrite_recv_fn fixed it

History

#1 Updated by modem7 over 1 year ago

Which version of Samba is Amahi 11 running currently?

#2 Updated by bigfoot65 over 1 year ago

Samba version 4.7.9 is being used in Amahi 11.

#3 Updated by cpg over 1 year ago

  • Status changed from New to Feedback
  • Assignee set to bigfoot65

here is a build. can you help test it out and provide feedback @modem7 ?
(if so, @bigfoot65 can provide a checklist of things to test out)

http://alpha.amahi.org/tmp/amahi-greyhole-0.10.17-1.x86_64.rpm

#4 Updated by modem7 over 1 year ago

cpg wrote:

here is a build. can you help test it out and provide feedback @modem7 ?
(if so, @bigfoot65 can provide a checklist of things to test out)

[...]

Installed now, awaiting any problems. If I don't respond, assume all is going as expected.

#5 Updated by modem7 over 1 year ago

modem7 wrote:

cpg wrote:

here is a build. can you help test it out and provide feedback @modem7 ?
(if so, @bigfoot65 can provide a checklist of things to test out)

[...]

Installed now, awaiting any problems. If I don't respond, assume all is going as expected.

Getting the following when attempting to start it:

[~]$ greyhole
PHP Warning: require_once(includes/common.php): failed to open stream: No such file or directory in /usr/bin/greyhole on line 22
PHP Fatal error: require_once(): Failed opening required 'includes/common.php' (include_path='.:/usr/share/pear:/usr/share/php') in /usr/bin/greyhole on line 22

For now, I have gone back to 0.10.15 until resolution

#6 Updated by bigfoot65 over 1 year ago

  • Assignee changed from bigfoot65 to cpg

Installed:

[amahi@localhost ~]$ sudo rpm -Uvh http://alpha.amahi.org/tmp/amahi-greyhole-0.10.17-1.x86_64.rpm
Retrieving http://alpha.amahi.org/tmp/amahi-greyhole-0.10.17-1.x86_64.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
Updating / installing...
   1:amahi-greyhole-0.10.17-1         ################################# [100%]
Created symlink /etc/systemd/system/multi-user.target.wants/amahi-greyhole.service → /usr/lib/systemd/system/amahi-greyhole.service.
Running as unit: run-rf38ff196448a420eaed90b7c5b85023c.service

Service won't start. Get the following:

[amahi@localhost ~]$ sudo systemctl status amahi-greyhole -l
● amahi-greyhole.service - Greyhole for Amahi
   Loaded: loaded (/usr/lib/systemd/system/amahi-greyhole.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Tue 2019-01-08 21:07:40 CST; 4s ago
  Process: 2895 ExecStopPost=/bin/rm -f /run/amahi-greyhole.pid (code=exited, status=0/SUCCESS)
  Process: 2887 ExecStart=/usr/bin/amahi-greyhole (code=exited, status=0/SUCCESS)
 Main PID: 2888 (code=exited, status=255)

Jan 08 21:07:40 localhost.localdomain systemd[1]: amahi-greyhole.service: Failed with result 'exit-code'.
Jan 08 21:07:40 localhost.localdomain systemd[1]: amahi-greyhole.service: Service hold-off time over, scheduling restart.
Jan 08 21:07:40 localhost.localdomain systemd[1]: Stopped Greyhole for Amahi.
Jan 08 21:07:40 localhost.localdomain systemd[1]: amahi-greyhole.service: Start request repeated too quickly.
Jan 08 21:07:40 localhost.localdomain systemd[1]: Failed to start Greyhole for Amahi.
Jan 08 21:07:40 localhost.localdomain systemd[1]: amahi-greyhole.service: Unit entered failed state.
Jan 08 21:07:40 localhost.localdomain systemd[1]: amahi-greyhole.service: Failed with result 'exit-code'.
Jan 08 21:07:41 localhost.localdomain systemd[1]: amahi-greyhole.service: Start request repeated too quickly.
Jan 08 21:07:41 localhost.localdomain systemd[1]: Failed to start Greyhole for Amahi.
Jan 08 21:07:41 localhost.localdomain systemd[1]: amahi-greyhole.service: Failed with result 'exit-code'.

I have Greyhole UI installed and a single drive in the pool along with one share selected.

#7 Updated by cpg over 1 year ago

I can reproduce this with a plain configuration (no config settings for ii other than the RPM one). I wonder if it's because there is a bad default GH configuration?

did you have a decent GH config or just the default? did you usually do this and work?

I note that it takes a few seconds to stop (about 25 or 30). the "exit-code" error is in fact strange.

#8 Updated by bigfoot65 over 1 year ago

  • Subject changed from Upgrade to Greyhole 0.10.17 to Upgrade to Greyhole 0.10.18 (was 0.10.17)

New version has been release.

Recommend we upgrade to it.

https://github.com/gboudreau/Greyhole/releases/download/0.10.19/greyhole-0.10.19.tar.gz

#9 Updated by bigfoot65 over 1 year ago

  • Subject changed from Upgrade to Greyhole 0.10.18 (was 0.10.17) to Upgrade to Greyhole 0.10.19 (was 0.10.17)

#10 Updated by bigfoot65 about 1 year ago

  • Subject changed from Upgrade to Greyhole 0.10.19 (was 0.10.17) to Upgrade to Greyhole 0.10.20 (was 0.10.17)

#11 Updated by cpg about 1 year ago

please test

     http://alpha.amahi.org/tmp/amahi-greyhole-0.10.20-1.x86_64.rpm

#12 Updated by bigfoot65 about 1 year ago

Tested and appears to be working fine.

If I find any issues, will report them. But so far it appears good.

#13 Updated by bigfoot65 about 1 year ago

Tested on my HDA overnight and worked as expected.

No issues. Recommend release for Fedora 25 & 27.

#14 Updated by bigfoot65 about 1 year ago

New update was released:

https://github.com/gboudreau/Greyhole/releases/download/0.10.21/greyhole-0.10.21.tar.gz

If you want to update it before release, I will test. Otherwise we can do this version later.

#15 Updated by bigfoot65 about 1 year ago

  • Subject changed from Upgrade to Greyhole 0.10.20 (was 0.10.17) to Upgrade to Greyhole 0.10.21 (was 0.10.17)

#16 Updated by bigfoot65 12 months ago

  • Subject changed from Upgrade to Greyhole 0.10.21 (was 0.10.17) to Upgrade to Greyhole 0.10.22 (was 0.10.17)
  • Status changed from Feedback to Assigned

Greyhole has released another update.

https://github.com/gboudreau/Greyhole/releases/download/0.10.22/greyhole-0.10.22.tar.gz

Amahi 11 is currently on 0.10.15.

#17 Updated by bigfoot65 12 months ago

  • Priority changed from Normal to Medium

#18 Updated by bigfoot65 12 months ago

  • Subject changed from Upgrade to Greyhole 0.10.22 (was 0.10.17) to Upgrade to Greyhole 0.10.23 (was 0.10.17)

New version released.

https://github.com/gboudreau/Greyhole/releases/download/0.10.23/greyhole-0.10.23.tar.gz

We are grossly behind on the Greyhole version.

#19 Updated by bigfoot65 8 months ago

  • Subject changed from Upgrade to Greyhole 0.10.23 (was 0.10.17) to Upgrade to Greyhole 0.10.24 (was 0.10.17)

New version released:

https://github.com/gboudreau/Greyhole/releases/download/0.10.24/greyhole-0.10.24.tar.gz

  • Fixing patch file for samba 4.10
  • Patch for compiling Samba on Alpine Linux
  • build_vfs.sh: correctly check which lib dir to put the greyhole.so symlink into
  • Support for Samba 4.11

Happy to test once you have it built.

#20 Updated by modem7 8 months ago

I'll happily be a secondary tester if required. I've done the inplace upgrade from previous Amahi so I might come across some unusual behaviour if any present.

bigfoot65 wrote:

New version released:

https://github.com/gboudreau/Greyhole/releases/download/0.10.24/greyhole-0.10.24.tar.gz

  • Fixing patch file for samba 4.10
  • Patch for compiling Samba on Alpine Linux
  • build_vfs.sh: correctly check which lib dir to put the greyhole.so symlink into
  • Support for Samba 4.11

Happy to test once you have it built.

#21 Updated by bigfoot65 4 months ago

  • Subject changed from Upgrade to Greyhole 0.10.24 (was 0.10.17) to Upgrade to Greyhole 0.11.2 (was 0.10.17)

#22 Updated by bigfoot65 3 months ago

  • Subject changed from Upgrade to Greyhole 0.11.2 (was 0.10.17) to Upgrade to Greyhole 0.12.1 (was 0.10.17)

#23 Updated by bigfoot65 3 months ago

  • Subject changed from Upgrade to Greyhole 0.12.1 (was 0.10.17) to Upgrade to Greyhole 0.12.2 (was 0.10.17)

#24 Updated by bigfoot65 3 months ago

  • Subject changed from Upgrade to Greyhole 0.12.2 (was 0.10.17) to Upgrade to Greyhole 0.12.3 (was 0.10.17)

#25 Updated by cpg 3 months ago

  • Status changed from Assigned to Feedback
  • Assignee changed from cpg to bigfoot65

Please try this and report

rpm -Uvh http://alpha.amahi.org/tmp/amahi-greyhole-0.12.3-1.x86_64.rpm

#26 Updated by bigfoot65 3 months ago

It appears to be working fine with the exception of this warning when Greyhole initially is started:

Greyhole VFS module (/usr/lib64/samba/vfs/greyhole.so) seems to be missing some required libraries. If you have issues connecting to your Greyhole-enabled shares, try to compile a new VFS module for Samba by running this command: /usr/share/greyhole/build_vfs.sh current

I think it's harmless as the shares appear to be working fine though.

#27 Updated by cpg 3 months ago

  • Status changed from Feedback to Assigned
  • Assignee changed from bigfoot65 to cpg

#28 Updated by cpg 3 months ago

  • Status changed from Assigned to Closed

amahi-greyhole-0.12.3-2 has been released with a fix for the warning in the greyhole log. great catch @bigfoot65!

this would probably not lead to corruption, however, almost for sure it would have led to failures eventually.

let's table this one and file new releases in a separate ticket(s).

Also available in: Atom