Project

General

Profile

Feature #746

Localized names of shares

Added by tarl over 10 years ago. Updated over 10 years ago.

Status:
Assigned
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
02/10/2011
Due date:
% Done:

100%


Description

Samba supports localized names of shares (e.g. Russian), so it would be good to have the possibility to use them in Amahi.

History

#1 Updated by cpg over 10 years ago

Good bug!
I did not realize this was not working well!

I have a patch, however, the best that i can seem to do is to allow the first char to be A-Za-z_
and the rest be localized.

I am looking for a suitable regular expression in ruby to match exactly all the legal share names, but i could not find one easily.
can you help by looking for this?

Would that be ok?

#2 Updated by cpg over 10 years ago

  • Status changed from New to Feedback

if you are using fedora 14 and only fedora 14, you can try a fix here:

IF YOU USE THIS RPM WITH A FEDORA 12 BOX, IT WILL BREAK IT AND WE WILL NOT BE ABLE TO HELP. ONLY A REISTALL WILL.

http://alpha.amahi.org/tmp/hda-platform-5.6.53-1.noarch.rpm

known issue: apparently the validation chokes with special chars (a javascript issue?) but other than that quirk, it ought to work.

Can you provide feedback?

#3 Updated by tarl over 10 years ago

Thanks cpg! I've installed your rpm and what's happened:

Now I'm able to create Russian share name as follows:
1) Start typing in the field "Name" some string like "zzz" following by the desired localized share name;
2) Then type localized folder name in field "Path";
3) Then erase "zzz" from the share name;
4) Click "Create this Share".

#4 Updated by Anonymous over 10 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:"0ff4d451ae90cada302f6a67f8d508f3c5d94863".

#5 Updated by cpg over 10 years ago

please try with this RPM (ONLY FOR Fedora 14!! NOT for F12!!):

rpm -Uvh http://alpha.amahi.org/tmp/hda-platform-5.6.55-1.noarch.rpm

also, please try the following as all have changed!

  • create a share with non-special names and paths with special chars
  • create a user with a special char or two in the username put a space (to make it invalid), then a special char, then remove the space to make it valid and make sure it works
  • similar with webapps

will update bug #749 next.

#6 Updated by tarl over 10 years ago

  • create a share with non-special names and paths with special chars

I've tried this and also I've tried to create a share with Russian chars in name and in path--all that worked like a charm.

  • create a user with a special char or two in the username put a space (to make it invalid), then a special char, then remove the space to make it valid and make sure it works
  • similar with webapps

I've been not able to create a user with Russian chars in username (even along with English chars) but I've been able to create a user with English chars only in name and Russian ones in full name (that's good enough for me).

I've been not able to create a webapp with Russian chars in name.

#7 Updated by cpg over 10 years ago

great.

we do not seem to figure out how to create (or if it's even possible) to have usernames ouside of [A-Za-z0-9].

but the checking does not stall, correct?

#8 Updated by tarl over 10 years ago

cpg wrote:

great.

we do not seem to figure out how to create (or if it's even possible) to have usernames ouside of [A-Za-z0-9].

but the checking does not stall, correct?

Yes, that's right.

#9 Updated by cpg over 10 years ago

please test this package with the latest tweaks, including creating users, shares and webapps:

http://alpha.amahi.org/tmp/hda-platform-5.6.56-1.noarch.rpm

#10 Updated by tarl over 10 years ago

cpg, my hda-platform was updated to version 5.6.59-1 since I've noticed your post.

Nevertheless nothing changed since my post 6, but I've noticed the following:
1. Amahi allows the proper English sharename to consist of 20 chars;
2. Amahi allows the proper Russian sharename to consist of 16 chars, but the input field allows 20 chars. Just when you enter the 17th char Amahi doesn't allow Share creation;
3. Nevertheless even if you delete the 17h char the button "Create this Share" doesn't react on mouse click. You need to delete the 16th char and input it again to activate this button.

#11 Updated by cpg over 10 years ago

  • Status changed from Closed to Assigned
  • Priority changed from Normal to Low

Great feedback!

Reopening ... with lower priority.

This is probably due to some unicode chars taking two bytes or something and the length being computed with those.

I really do not know much about unicode and localization, so we will have to get some advice as to how to compute the "length" of a unicode string!

Also available in: Atom